Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of the USL API #2469

Closed
wants to merge 2 commits into from
Closed

First draft of the USL API #2469

wants to merge 2 commits into from

Conversation

theo25
Copy link
Collaborator

@theo25 theo25 commented Jun 6, 2024

This is a first draft for the low-level API that will be used to communicate with the DSL.

Note that many of the data types used in this draft are simply 64-bit integers. These are placeholders and I welcome your input as to what would be a recommended data type for each such placeholder.

@theo25 theo25 requested a review from dwightguth June 6, 2024 18:16
@theo25 theo25 requested a review from Robertorosmaninho June 6, 2024 18:16
@ehildenb
Copy link
Member

ehildenb commented Jun 6, 2024

Are we sure this needs to be merged into KEVM? Would it be more appropriate as a repo on the pi2 side that includes KEVM?

@ehildenb
Copy link
Member

ehildenb commented Jun 6, 2024

At the very least, if it's to be merged into KEVM, then it should come with a testing harness here as well, and some tests of basic functionality/sanity, because it will become the responsibility of our team to maintain this functionality over time (rather than pi2 team) when we need to make changes.

@theo25
Copy link
Collaborator Author

theo25 commented Jun 6, 2024

@ehildenb I tend to agree that this should probably live somewhere in the pi2 side. I put it here for now because it was the faster way to have the kevm runtime available to link with.

And of course, I agree that we need significant test harness. This is just a draft so that we can come to an agreement as to what this API should look like and specifically what kind of information needs to be communicated between KEVM and the USL client for executing transactions.

By the way, I am happy to add you as reviewer and get your input if you have the time.

@theo25 theo25 requested a review from ehildenb June 6, 2024 18:26
@theo25
Copy link
Collaborator Author

theo25 commented Jun 10, 2024

I have added a similar PR to our Pi2 fork of the EVM semantics and I am closing this one. We will be working on this on the fork and eventually push here when things are finalized and well-tested.

@theo25 theo25 closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants